Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change SDX-LC swagger spec to comply with topology spec 2.0.0 #158

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Change SDX-LC swagger spec to comply with topology spec 2.0.0 #158

merged 4 commits into from
Jul 29, 2024

Conversation

italovalcy
Copy link
Contributor

@italovalcy italovalcy commented Jul 25, 2024 •
edited
Loading

Fix #157

Description of the change

  • Changed attributes on the swagger/openapi yaml file to comply with Topology Data Model spec 2.0.0
  • Removed examples from the swagger spec (easy to maintain)
  • port model updated to add new fields (mtu and type)
  • updated unit tests to adjust for the new openapi definition.
  • renamed private_attributes to private (removed from Node, which does not have any attribute allowed to be private)

Italo Valcy added 2 commits July 25, 2024 04:56
changing swagger spec to comply with topology spec 2.0.0 - removed ex…
3f981b7 
…amples
Fix tests, port model and swagger openapi for topo 2.0.0
710327f 
- port model: adding type and mtu attributes and minimally comply with topo 2.0.0
- swagger/openapi: separated definition of connection port (which diverge from topology.port)
- tests/*: adjustment on the test to minimally comply with topo 2.0.0
@coveralls
Copy link

coveralls commented Jul 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10152088123

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 25 of 26 (96.15%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.09%) to 78.056%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_lc/models/port.py 19 20 95.0%
Files with Coverage Reduction New Missed Lines %
sdx_lc/models/node.py 1 86.36%
sdx_lc/models/port.py 1 88.6%
sdx_lc/models/link.py 2 92.8%
Totals Coverage Status
Change from base Build 10077763335: 0.09%
Covered Lines: 1221
Relevant Lines: 1500
💛 - Coveralls

@italovalcy italovalcy marked this pull request as ready for review July 25, 2024 19:45
congwang09
congwang09 reviewed Jul 29, 2024
View reviewed changes
sdx_lc/models/port.py Outdated Show resolved Hide resolved
@italovalcy italovalcy merged commit f9a5fc3 into main Jul 29, 2024
9 checks passed
@italovalcy italovalcy deleted the fix/issue_157 branch July 29, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congwang09 congwang09 congwang09 approved these changes

@YufengXin YufengXin Awaiting requested review from YufengXin

@sajith sajith Awaiting requested review from sajith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New topology data model spec 2.0.0 and swagger server openapi spec
3 participants
@italovalcy @coveralls @congwang09